New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select only node that is running #170

Merged
merged 2 commits into from Feb 14, 2018

Conversation

Projects
None yet
5 participants
@alex-slynko
Member

alex-slynko commented Feb 2, 2018

If node got renamed during upgrade, post-start script fails.
After the fix, post-start script selects only the active node, and not old node that will be eventually removed

Select only node that is running
If node got renamed during upgrade, post-start script fails.
@cfdreddbot

This comment has been minimized.

cfdreddbot commented Feb 2, 2018

Hey alex-slynko!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot

This comment has been minimized.

cf-gitbot commented Feb 2, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/154880185

The labels on this github issue will be updated when the story is started.

@Manifaust Manifaust self-assigned this Feb 9, 2018

@jhvhs jhvhs merged commit 02021d5 into master Feb 14, 2018

1 check passed

security/snyk - Gemfile.lock No dependency changes
Details

@cf-gitbot cf-gitbot removed the unscheduled label Feb 14, 2018

@jhvhs jhvhs deleted the bad-kubelet-breaks-upgrade branch Feb 14, 2018

@cf-gitbot cf-gitbot added the accepted label Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment