New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-controller-manager: ca.pem remove new line #184

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
4 participants
@alekssaul

alekssaul commented Mar 6, 2018

Removes new line from the end of ca.pem file used by kube-controller-manager.

New line causes the secrets for service accounts to be generated with data/ca.crt having an additional new line. This causes issues with applications (ie: Spark on K8s) that use Java K8s client (https://github.com/fabric8io/kubernetes-client).

image

Aleks Saul
kube-controller-manager: ca.pem remove new line
Removes new line from the end of ca.pem file used by kube-controller-manager
@cfdreddbot

This comment has been minimized.

cfdreddbot commented Mar 6, 2018

Hey alekssaul!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

@cf-gitbot

This comment has been minimized.

cf-gitbot commented Mar 6, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155731214

The labels on this github issue will be updated when the story is started.

@alekssaul

This comment has been minimized.

alekssaul commented Mar 6, 2018

Hi,
Part of Pivotal-Field-Engineering org, do I need to submit a CLA?

@BenChapman

This comment has been minimized.

Contributor

BenChapman commented Mar 6, 2018

@alekssaul

Thank you for the submission. You'll need to publicise your membership of that org as per the instructions of the bot:

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Thanks,
Ben.

@alekssaul

This comment has been minimized.

alekssaul commented Mar 6, 2018

Thanks @BenChapman , sorry I missed the org visibility, should be ok now.

@BenChapman BenChapman closed this Mar 6, 2018

@BenChapman BenChapman reopened this Mar 6, 2018

@cfdreddbot

This comment has been minimized.

cfdreddbot commented Mar 6, 2018

Hey alekssaul!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot cf-gitbot removed the unscheduled label Mar 6, 2018

@cf-gitbot

This comment has been minimized.

cf-gitbot commented Mar 6, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155743927

The labels on this github issue will be updated when the story is started.

@BenChapman BenChapman merged commit 465ba11 into cloudfoundry-incubator:master Mar 6, 2018

2 checks passed

concourse-ci/status Concourse CI build success
Details
security/snyk - Gemfile.lock No dependency changes
Details

@cf-gitbot cf-gitbot removed the unscheduled label Mar 6, 2018

@BenChapman

This comment has been minimized.

Contributor

BenChapman commented Mar 6, 2018

Thank you for the pull request! We've merged this, and it should be available in the next version of CFCR.

@alekssaul alekssaul deleted the alekssaul:kube-ctrl-newline branch Mar 6, 2018

@cf-gitbot cf-gitbot added delivered accepted and removed delivered labels Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment