Skip to content

/ kubo-release

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables kube-controller-manager to issue certificates #187

Closed
wants to merge 1 commit into from
Closed

Enables kube-controller-manager to issue certificates #187

wants to merge 1 commit into from

Conversation

@bsnchan
Copy link
Contributor

@bsnchan bsnchan commented Mar 16, 2018

  • this is required by the webhook-create-signed-cert.sh script
    required to install istio sidecar

https://istio.io/docs/setup/kubernetes/sidecar-injection#installing-the-webhook
@bsnchan
Enables kube-controller-manager to issue certificates
Loading status checks…
482474e 
* this is required by the `webhook-create-signed-cert.sh` script
required to install istio sidecar
https://istio.io/docs/setup/kubernetes/sidecar-injection#installing-the-webhook
@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Mar 16, 2018

Hey bsnchan!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.
@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Mar 16, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/156052808

The labels on this github issue will be updated when the story is started.
bsnchan added a commit to bsnchan/kubo-deployment that referenced this pull request Mar 16, 2018
@bsnchan
Adds cluster-signing property for the kube-controller-manager job
02e4bb5 
* cloudfoundry-incubator/kubo-release#187
@bsnchan bsnchan mentioned this pull request Mar 16, 2018
Merged
@mordebites
Copy link
Contributor

@mordebites mordebites commented Mar 20, 2018

Hi @bsnchan,
our PMs will take a look and prioritise this. Could you please add some tests so we can run this in our pipeline?
@bsnchan
Copy link
Contributor Author

@bsnchan bsnchan commented Mar 20, 2018

Hey @mordebites - I'm not sure what tests you want since there is no BOSH templating logic around the cluster-signing configuration. Did you want me to add an integration test in the kubo-ci repo instead?
@glestaris
Copy link

@glestaris glestaris commented Mar 21, 2018

hey @bsnchan, see comment for cloudfoundry-incubator/kubo-deployment#281.
@bsnchan bsnchan closed this Mar 27, 2018
@bsnchan bsnchan mentioned this pull request Apr 24, 2018
Merged
tvs added a commit to cloudfoundry-incubator/kubo-deployment that referenced this pull request Apr 24, 2018
@bsnchan @tvs
Adds cluster-signing property for the kube-controller-manager job (#281)
392d22f 
* cloudfoundry-incubator/kubo-release#187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@bsnchan @cfdreddbot @cf-gitbot @mordebites @glestaris