/kubo-release

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables kube-controller-manager to issue certificates #187

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
5 participants
@bsnchan @cfdreddbot @cf-gitbot @mordebites @glestaris
@bsnchan
Contributor

bsnchan commented Mar 16, 2018

  • this is required by the webhook-create-signed-cert.sh script
    required to install istio sidecar

https://istio.io/docs/setup/kubernetes/sidecar-injection#installing-the-webhook
@bsnchan
Enables kube-controller-manager to issue certificates 
* this is required by the `webhook-create-signed-cert.sh` script
required to install istio sidecar
https://istio.io/docs/setup/kubernetes/sidecar-injection#installing-the-webhook
482474e
@cfdreddbot

This comment has been minimized.

Sign in to view

cfdreddbot commented Mar 16, 2018

Hey bsnchan!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.
@cf-gitbot

This comment has been minimized.

Sign in to view

cf-gitbot commented Mar 16, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/156052808

The labels on this github issue will be updated when the story is started.

@cf-gitbot cf-gitbot added the unscheduled label Mar 16, 2018

bsnchan added a commit to bsnchan/kubo-deployment that referenced this pull request Mar 16, 2018

@bsnchan
Adds cluster-signing property for the kube-controller-manager job 
* cloudfoundry-incubator/kubo-release#187
02e4bb5

@bsnchan bsnchan referenced this pull request Mar 16, 2018

Merged

Adds cluster-signing property for the kube-controller-manager job #281

@mordebites

This comment has been minimized.

Sign in to view
Contributor

mordebites commented Mar 20, 2018

Hi @bsnchan,
our PMs will take a look and prioritise this. Could you please add some tests so we can run this in our pipeline?
@bsnchan

This comment has been minimized.

Sign in to view
Contributor

bsnchan commented Mar 20, 2018

Hey @mordebites - I'm not sure what tests you want since there is no BOSH templating logic around the cluster-signing configuration. Did you want me to add an integration test in the kubo-ci repo instead?
@glestaris

This comment has been minimized.

Sign in to view
Member

glestaris commented Mar 21, 2018

hey @bsnchan, see comment for cloudfoundry-incubator/kubo-deployment#281.

@bsnchan bsnchan closed this Mar 27, 2018

@cf-gitbot cf-gitbot added delivered accepted and removed unscheduled delivered labels Mar 27, 2018

@bsnchan bsnchan referenced this pull request Apr 24, 2018

Merged

Enables kube-controller-manager to issue certificates #199

tvs added a commit to cloudfoundry-incubator/kubo-deployment that referenced this pull request Apr 24, 2018

@bsnchan @tvs
Adds cluster-signing property for the kube-controller-manager job (#281) 
* cloudfoundry-incubator/kubo-release#187
392d22f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment