New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the BOSH instance ID to the node labels #190

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
5 participants
@frodenas
Contributor

frodenas commented Mar 26, 2018

This will allow the NSX-T NCP component to match the k8s node with the underlying VM when using the vSphere CPI with NSX-T enabled, as it also tags the VM with the same BOSH instance ID.

@cfdreddbot

This comment has been minimized.

cfdreddbot commented Mar 26, 2018

Hey frodenas!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

@cf-gitbot

This comment has been minimized.

cf-gitbot commented Mar 26, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/156262561

The labels on this github issue will be updated when the story is started.

Add the BOSH instance ID to the node labels
This will allow the NSX-T NCP component to match the k8s node with
the underlying VM when using the vSphere CPI with NSX-T enabled, as
it also tags the VM with the same BOSH instance ID.

@iainsproat iainsproat merged commit 79886e5 into cloudfoundry-incubator:master Apr 16, 2018

1 check passed

concourse-ci/status Concourse CI build success
Details

@cf-gitbot cf-gitbot removed the in progress label Apr 16, 2018

@frodenas frodenas deleted the frodenas:bosh-id-node-label branch Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment