New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables kube-controller-manager to issue certificates #199

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
4 participants
@bsnchan
Contributor

bsnchan commented Apr 24, 2018

This is a followup from #187 (GitHub wouldn't allow me to reopen the PR).

  • this is required by the webhook-create-signed-cert.sh script
    required to install istio sidecar

https://istio.io/docs/setup/kubernetes/sidecar-injection#installing-the-webhook

Notes

Enables kube-controller-manager to issue certificates
* this is required by the `webhook-create-signed-cert.sh` script
required to install istio sidecar
https://istio.io/docs/setup/kubernetes/sidecar-injection#installing-the-webhook
@cf-gitbot

This comment has been minimized.

cf-gitbot commented Apr 24, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/157048572

The labels on this github issue will be updated when the story is started.

@cfdreddbot

This comment has been minimized.

cfdreddbot commented Apr 24, 2018

Hey bsnchan!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@tvs

tvs approved these changes Apr 24, 2018

@cf-gitbot cf-gitbot added in progress and removed scheduled labels Apr 24, 2018

@tvs tvs merged commit b1b52e3 into cloudfoundry-incubator:master Apr 24, 2018

andyliuliming added a commit to andyliuliming/kubo-release that referenced this pull request Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment