Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote vsphere user in cloud-provider config file #229

Merged
merged 1 commit into from Jul 13, 2018

Conversation

Projects
None yet
6 participants
@angelachin
Copy link
Member

angelachin commented Jul 10, 2018

What this PR does / why we need it:
This PR allows users to specify NTLM-formatted usernames for VSphere.

Previously, when you tried to provide a NTLM-formatted username the kube-cloud-controller manager would produce the following error:

14:26:12.175060       1 controllermanager.go:159] error building controller context: cloud provider could not be initialized: could not init cloud provider "vsphere": 3:6: unquoted '\' must be followed by new line

How can this PR be verified?
This can be verified by using a NTLM-formatted username as a parameter in the manifest. Here is an example ops-file:

- type: replace
  path: /instance_groups/name=master/jobs/name=cloud-provider/properties/cloud-provider/vsphere/user?
  value: "vsphere.local\example-user"

Is there any change in kubo-deployment?
No

Is there any change in kubo-ci?
No

Does this affect upgrade, or is there any migration required?
No

Which issue(s) this PR fixes:
n/a

Quote vsphere user in cloud-provider config file
[#158904932]

Signed-off-by: Angela Chin <achin@pivotal.io>
@cf-gitbot

This comment has been minimized.

Copy link

cf-gitbot commented Jul 10, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/158949005

The labels on this github issue will be updated when the story is started.

@cfdreddbot

This comment has been minimized.

Copy link

cfdreddbot commented Jul 10, 2018

Hey chinangela!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@henderjm

This comment has been minimized.

Copy link
Contributor

henderjm commented Jul 11, 2018

LGTM

@henderjm henderjm self-requested a review Jul 11, 2018

@alex-slynko

This comment has been minimized.

Copy link
Member

alex-slynko commented Jul 13, 2018

We will run it through CI and merge it later

@alex-slynko alex-slynko merged commit c9294bb into master Jul 13, 2018

1 check was pending

concourse-ci/status Concourse CI build pending
Details

@cf-gitbot cf-gitbot removed the unscheduled label Jul 13, 2018

@alex-slynko alex-slynko deleted the vsphere-ntlm-username-fix-#158904932 branch Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.