allow secure db connection #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey qibobo! The commit authors and yourself have already signed the CLA. |
|
This PR can enable tls connection between postgres database server and autoscaler java&golang components(scheduler, metricscollector, eventgenerator, scalingengine and operator). For nodejs components(apiserver and servicebroker), code change is need in repo(https://github.com/cloudfoundry/app-autoscaler) and after the code change we will bump it to enable tls connection for apiserver and servicebroker. |
cdlliuy
reviewed
Mar 11, 2019
| @@ -59,6 +66,10 @@ properties: | |||
| description: "Port on which the appmetricsdb server will listen" | |||
| autoscaler.appmetrics_db.roles: | |||
| description: "The list of database roles used in appmetricsdb database including name/password" | |||
| autoscaler.appmetrics_db.tls.ca: | |||
|
@cdlliuy |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.