Run migration and save migration version in single transaction #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amelia Downs <adowns@vmware.com> Signed-off-by: Maria Shaldybin <mariash@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
BBS runs each migration and saves latest migration version in the database. We want these operations to happens in a single transaction so that if saving migration version fails migration will not be applied and BBS will try to run migration again.
We found out that DDL changes in MySQL cannot be rolled back. So this will only be an improvement for Postgres databases. Next step we should add test to make sure migrations are idempotent.
How should this change be described in diego-release release notes?
Tag your pair, your PM, and/or team!
@ameowlia
Thank you!