Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use reserved characters in Windows filenames #612

Merged
merged 1 commit into from Mar 16, 2023
Merged

Don't use reserved characters in Windows filenames #612

merged 1 commit into from Mar 16, 2023

Conversation

selzoc
Copy link
Member

@selzoc selzoc commented Mar 10, 2023

Fixes 611

@selzoc
Don't use reserved characters in Windows filenames
a9c6072 
Authored-by: Chris Selzo <cselzo@vmware.com>
@selzoc selzoc mentioned this pull request Mar 10, 2023
Closed
lnguyen
lnguyen approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@lnguyen lnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkoster rkoster merged commit 4395744 into main Mar 16, 2023
2 checks passed
@rkoster rkoster deleted the windows-create-release-fix branch March 16, 2023 15:41
selzoc added a commit to selzoc/winfs-injector that referenced this pull request Apr 4, 2023
@selzoc
fix: Bump bosh-cli to enable Windows execution
41a9659 
Previously, the bosh-cli attempted to create files with a ":" in the
name, which is not allowed on Windows. This incorporates cloudfoundry/bosh-cli#612,
which substitutes the "_" character on Windows.

Authored-by: Chris Selzo <cselzo@vmware.com>
@selzoc selzoc mentioned this pull request Apr 4, 2023
Closed
@staylor14 staylor14 mentioned this pull request Apr 5, 2023
Merged
staylor14 pushed a commit to pivotal-cf/winfs-injector that referenced this pull request Apr 5, 2023
@selzoc @staylor14
fix: Bump bosh-cli to enable Windows execution
c7c22d2 
Previously, the bosh-cli attempted to create files with a ":" in the
name, which is not allowed on Windows. This incorporates cloudfoundry/bosh-cli#612,
which substitutes the "_" character on Windows.

Authored-by: Chris Selzo <cselzo@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkoster rkoster rkoster approved these changes

@lnguyen lnguyen lnguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating releases with blobs are broken on Windows
3 participants
@selzoc @rkoster @lnguyen