Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local ssd #309

Merged
merged 1 commit into from Sep 29, 2020
Merged

Local ssd #309

merged 1 commit into from Sep 29, 2020

Conversation

stigtermichiel
Copy link
Contributor

Hi there,

referencing issue #152

This is a first draft for a pull request implementing support for local ssd's. Currently only supports adding one ssd with the fixed size (I have no clue how attaching multiple ssd's would work). I can't get the integration tests to work, but I created a local release and tested it succesfully. Altough we needed this pull request: cloudfoundry/garden-runc-release#129 to be solved.

Only supports nvme for now, but it should be easy to support scsi as well.

Hopefully, third time lucky regarding the cla..

@cfdreddbot
Copy link

✅ Hey stigtermichiel! The commit authors and yourself have already signed the CLA.

@evandbrown evandbrown requested a review from tysen March 11, 2019 18:07
@tysen tysen removed their request for review May 3, 2019 19:17
@gerhard
Copy link

gerhard commented Sep 17, 2019

I was just looking for this feature. Are you still interested in seeing it through @stigtermichiel ?

@simonjohansson
Copy link

@gerhard yeah, we have run this in production since the PR was submitted without any issues :)

@gerhard
Copy link

gerhard commented Dec 19, 2019

Thanks @simonjohansson!

@dpb587 is this on your radar? cc @tysen @evandbrown

@stigtermichiel
Copy link
Contributor Author

Sorry @gerhard, totally missed your message!

@simonjohansson
Copy link

@evandbrown @jfmyers9 ping pong

@simonjohansson
Copy link

Monthly ping

@mrosecrance
Copy link
Member

We're going to take a deeper look a this in the next month or so, but there's a few things that can be done first.

Why are there so many docs changes baked into this PR? This repo isn't a good place to keep things like docs on deploying CF - they're maintained elsewhere and some of these docs already have stale references to things like trusty. It also looks like some of the docs are not at all gcp specific. At the very least the docs changes should be pulled into a separate PR.

Also can you resolve the conflicts?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 9, 2020

CLA Check
The committers are authorized under a signed CLA.

@stigtermichiel
Copy link
Contributor Author

My apologies, that must have happened when I tried to merge the develop branch in my branch. I will cherrypick the commits.

Signed-off-by: michiel <michiel.stigter@springer.com>
@rkoster rkoster merged commit d6334a0 into cloudfoundry:develop Sep 29, 2020
@rkoster
Copy link
Contributor

rkoster commented Sep 29, 2020

@stigtermichiel Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants