Making BOSH docs more apparent #1

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@PharkMillups

I poured over this repo for a while but couldn't find any actual docs on BOSH itself. Mr. Watters was kind enough to point me at them [1] but I suspect you'll want to make it easier to find them. This README tweak makes their location more apparent.

[1] https://twitter.com/#!/wattersjames/status/190156684130398208

@vmware-ac-gerrit

This comment has been minimized.

Show comment Hide comment
@vmware-ac-gerrit

vmware-ac-gerrit Apr 11, 2012

Dear Cloud Foundry contributor,

If you are reading this message, it means you submitted a pull request in the Cloud Foundry GitHub repository.

First of all, thanks! We really appreciate your participation.

Recently we made some changes in how we are verifying and reviewing open source contributions like yours. In addition, we changed the way we can expose our internal development in real-time. The changes are exciting, as they allow all our staff to collaborate seamlessly with you, which increases our mutual velocity and gives the community a bigger stake in our direction.

The Cloud Foundry team uses Gerrit, a code review tool that originated in the Android Open Source Project. We also use GitHub as an official mirror, though all pull requests are accepted via Gerrit.

Follow these steps to make a contribution to any of our open source repositories:

  1. Complete our CLA Agreement for
    individuals or
    corporations.

  2. Sign up for an account on our public Gerrit server at
    http://reviews.cloudfoundry.org/.

  3. Create and upload your public SSH key in your Gerrit account profile.

  4. Set your name and email:

            git config --global user.name "Firstname Lastname"
            git config --global user.email "your_email@youremail.com"
    
  5. Install our gerrit-cli gem:

            gem install gerrit-cli
    
  6. Clone the Cloud Foundry repo:
    Note: to clone the BOSH repo, or the Documentation repo, replace
    vcap with bosh or oss-docs

            gerrit clone ssh://reviews.cloudfoundry.org:29418/vcap
            cd vcap
    
  7. Make your changes, commit, and push to gerrit:

            git commit
            gerrit push
    

Once your commits are approved by our Continuous Integration Bot (CI Bot) as well as our engineering staff, return to the Gerrit interface and MERGE your changes. The merge will be replicated to GitHub automatically at https://github.com/cloudfoundry. If you get feedback on your submission, we recommend squashing your commit with the original change-id. See the squashing section here for more details: https://help.github.com/rebase.

Dear Cloud Foundry contributor,

If you are reading this message, it means you submitted a pull request in the Cloud Foundry GitHub repository.

First of all, thanks! We really appreciate your participation.

Recently we made some changes in how we are verifying and reviewing open source contributions like yours. In addition, we changed the way we can expose our internal development in real-time. The changes are exciting, as they allow all our staff to collaborate seamlessly with you, which increases our mutual velocity and gives the community a bigger stake in our direction.

The Cloud Foundry team uses Gerrit, a code review tool that originated in the Android Open Source Project. We also use GitHub as an official mirror, though all pull requests are accepted via Gerrit.

Follow these steps to make a contribution to any of our open source repositories:

  1. Complete our CLA Agreement for
    individuals or
    corporations.

  2. Sign up for an account on our public Gerrit server at
    http://reviews.cloudfoundry.org/.

  3. Create and upload your public SSH key in your Gerrit account profile.

  4. Set your name and email:

            git config --global user.name "Firstname Lastname"
            git config --global user.email "your_email@youremail.com"
    
  5. Install our gerrit-cli gem:

            gem install gerrit-cli
    
  6. Clone the Cloud Foundry repo:
    Note: to clone the BOSH repo, or the Documentation repo, replace
    vcap with bosh or oss-docs

            gerrit clone ssh://reviews.cloudfoundry.org:29418/vcap
            cd vcap
    
  7. Make your changes, commit, and push to gerrit:

            git commit
            gerrit push
    

Once your commits are approved by our Continuous Integration Bot (CI Bot) as well as our engineering staff, return to the Gerrit interface and MERGE your changes. The merge will be replicated to GitHub automatically at https://github.com/cloudfoundry. If you get feedback on your submission, we recommend squashing your commit with the original change-id. See the squashing section here for more details: https://help.github.com/rebase.

@PharkMillups

This comment has been minimized.

Show comment Hide comment
@PharkMillups

PharkMillups Apr 11, 2012

Really? I need a CLA in place just to make a 5 line, non-code change to a README?

Really? I need a CLA in place just to make a 5 line, non-code change to a README?

@PharkMillups

This comment has been minimized.

Show comment Hide comment
@PharkMillups

PharkMillups Apr 11, 2012

I took the lazy road and filed an issue for this: #2

I understand VMware needs a CLA, but you'll probably get a lot more people filing issues for small fixes as opposed to actually fixing them with this in place. I'm not sure there's much you can do about it as CLAs tend to be all or nothing, but it's unfortunate.

Anyways, looking forward to watching BOSH grow. Looks like a promising chunk of code.

I took the lazy road and filed an issue for this: #2

I understand VMware needs a CLA, but you'll probably get a lot more people filing issues for small fixes as opposed to actually fixing them with this in place. I'm not sure there's much you can do about it as CLAs tend to be all or nothing, but it's unfortunate.

Anyways, looking forward to watching BOSH grow. Looks like a promising chunk of code.

olegshaldibin added a commit that referenced this pull request Jun 22, 2012

Fixed release upload regression
Recent package matching optimization required an updated director to
work properly. We tried to make it backward compatible by doing full
matching when talking to the older director but it wasn't enough: the
list of packages fetched from director has no information of which
version a package belongs to, so CLI could delete more packages than
needed trying to repack the tarball. Fixed by making change work exactly
as it was working before: if no package matching can be performed,
exhaustive name/version comparison is performed instead of just sha1
comparison.

This should make it work with both old and new director as advertised.

Test plan:

- uploaded release to older director;
- uploaded release to new director;
- changed release name and retried #1 and #2.

Change-Id: I457c6c399db6b2cea12e4b4ef9c0d93c65c82013

m1093782566 pushed a commit to m1093782566/bosh that referenced this pull request Jan 14, 2014

Merge pull request #1 from cloudfoundry-community/delete-ephemeral-vo…
…lume

Fix a bug that the ephemeral volume is not deleted along with the vm.

wayneeseguin pushed a commit to wayneeseguin/bosh that referenced this pull request Jun 13, 2015

Merge pull request #1 from Kaixiang/master
fix some agent properties to avoid agent fail after instance created.

jmcarp pushed a commit to jmcarp/bosh that referenced this pull request Jul 6, 2016

dpb587-pivotal pushed a commit that referenced this pull request Aug 7, 2017

Merge pull request #1 from Everlag/pr1
Introduce GcscliBlobstoreClient to bosh-director
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment