Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Enable provisioned iops EBS volume support for service nodes #102

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

pmenglund commented Mar 28, 2013

👎 we need to implement disk flavors to be able to support this, as we currently can't pass cloud properties to the disk creation, so your code doesn't work - it isn't guaranteed that there is an instance tied to the disk creation

Member

Kaixiang commented Mar 29, 2013

It's tested and I do create instances with io1 disk attached. see my env here
https://console.aws.amazon.com/ec2/home?region=us-east-1#s=Volumes

I put iops option in registry when creating instance(so can be pass from cloud properties), and read the registry for instance while create_disk given an instance_id.
we only need iops disk attached to some instance like services right? so instance_id is always valid while doing that.

Member

Kaixiang commented Mar 29, 2013

and the aws setup is shanghai

Contributor

pmenglund commented Mar 29, 2013

I'm not doubting that the code works, but the problem is that we need a generic solution to the problem of having different kinds of disks, and this only solves it for AWS (and in a hacky way as you stash config data in the registry).

I'd rather see you work on that...

Member

Kaixiang commented Apr 1, 2013

Thanks Martin... I see.
here is another attempt #106

@ajackson ajackson closed this Apr 1, 2013

@Kaixiang Kaixiang deleted the service_iops_wip branch Apr 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment