New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BOSH_COLOR env var for implicit --no-color #975

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@jhunt
Contributor

jhunt commented Oct 11, 2015

If BOSH_COLOR is set to the string "false", then the bosh' utility will behave as if the--no-coloroption has been set. This behavior can be overridden by also passing--color` (which takes precedence)

If BOSH_COLOR is not set, or has any other value, the previous default
behavior holds (only do color if we are hooked up to a terminal)

Support BOSH_COLOR env var for implicit --no-color
If BOSH_COLOR is set to the string "false", then the `bosh' utility will
behave as if the `--no-color` option has been set.  This behavior can be
overridden by also passing `--color` (which takes precedence)

If BOSH_COLOR is not set, or has any other value, the previous default
behavior holds (only do color if we are hooked up to a terminal)
@cfdreddbot

This comment has been minimized.

Show comment
Hide comment
@cfdreddbot

cfdreddbot Oct 11, 2015

Hey filefrog!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

cfdreddbot commented Oct 11, 2015

Hey filefrog!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

@jhunt

This comment has been minimized.

Show comment
Hide comment
@jhunt

jhunt Oct 11, 2015

Contributor

There are no tests for this, since I could find no pre-existing tests for --no-color / --color options to the bosh utility.

If anyone has any suggestions on the best way to architect such tests, I'm willing to implement them.

Contributor

jhunt commented Oct 11, 2015

There are no tests for this, since I could find no pre-existing tests for --no-color / --color options to the bosh utility.

If anyone has any suggestions on the best way to architect such tests, I'm willing to implement them.

@jhunt

This comment has been minimized.

Show comment
Hide comment
@jhunt

jhunt Oct 11, 2015

Contributor

Also, this implements #769

Contributor

jhunt commented Oct 11, 2015

Also, this implements #769

@cppforlife

This comment has been minimized.

Show comment
Hide comment
@cppforlife

cppforlife Nov 2, 2015

Member

In CLI 1.3120.0

Member

cppforlife commented Nov 2, 2015

In CLI 1.3120.0

@cppforlife cppforlife closed this Nov 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment