Add minimum_candidate_stagers to manifest template

[ScarletTanager]

[#119362989]

Signed-off-by: Dan Lavine dlavine@us.ibm.com

[cfdreddbot]

Hey ScarletTanager!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/120018459

The labels on this github issue will be updated when the story is started.

[Amit-PivotalLabs]

Any reason this default of 5 isn't in the job spec rather than the manifest template @ScarletTanager @DanLavine?

[ghost]

@Amit-PivotalLabs,

There is already a default of 5 in the job spec. However it seems kind of odd when looking at a manifest that was generated and this field having a nil value. We are just following the same scheme where the value of nil does not make much sense. (i.e. staging_disk_limit_mb)

/cc @ScarletTanager

[Amit-PivotalLabs]

Sorry, I don't quite understand. Is there some functional reason why the default value from the spec needs to be duplicated in the template (which is something we strongly try to avoid), or is it just that the manifest looks odd?

[ghost]

@Amit-PivotalLabs

It is just to make the generated manifest more readable. There is no technical reason that the values need to be duplicated. We are just being consistent in how these descriptive values are in both places.

[Amit-PivotalLabs]

We strongly avoid duplicating default values in job specs and the manifest templates. If we are consistently doing this in other places in the manifest templates, we should remove those as well. How the manifest reads is less important at this time. Thanks for the PR, but will close it out for now.