Add PATCH support to SCIM library #6

Merged
merged 2 commits into from May 8, 2014

Conversation

Projects
None yet
8 participants
Contributor

aocole commented Oct 25, 2013

From the SCIM spec [1], "Resources such as Groups may be very large hence implementers SHOULD support PATCH to enable partial resource modifications."

These changes add PATCH support to cf-uaa-lib so that it may be used if/when UAA's SCIM endpoint support PATCH requests. Test included.

[1] http://www.simplecloud.info/specs/draft-scim-api-01.html#rfc.section.3.3

@calebamiles calebamiles reopened this Oct 30, 2013

Contributor

aocole commented Nov 18, 2013

Hi @calebamiles
Any news on when this might be merged? Or anything that it needs before it can be merged?
Thanks
Andrew

jfoley commented Apr 18, 2014

@aocole - apologies that this slipped through the cracks for so long!
@dsyer - Does this look like something that you want to pull in to this library?

CF Community Pair (@chou & @jfoley)

Contributor

dsyer commented Apr 18, 2014

There isn't much point if the UAA doesn't have PATCH support, but on the other hand, the reason we didn't implement PATCH in the UAA is because there weren't any clients that supported it. Chicken and egg. I don't have any objection if it doesn't break any existing code paths.

Contributor

aocole commented Apr 21, 2014

Sounds like a green light to me. Merge it!

@rmorgan Do you want to story for this in your icebox or do you just want to pull it in?

Thanks,
CF Community Pair (@adamstegman & @jtuchscherer)

rmorgan commented Apr 29, 2014

Thanks @adamstegman - I'd like a quick review from the team, added https://www.pivotaltracker.com/story/show/70391612 to our icebox.

Member

fhanik commented Apr 29, 2014

@pjk25 @rdgallagher
Gents, this one is for your review

pjk25 added a commit that referenced this pull request May 8, 2014

Merge pull request #6 from aocole/master
Add PATCH support to SCIM library

@pjk25 pjk25 merged commit 4b94e14 into cloudfoundry:master May 8, 2014

1 check passed

default The Travis CI build passed
Details
Contributor

aocole commented May 8, 2014

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment