Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new autopilot cli-plugin application #282

Merged
merged 4 commits into from Feb 13, 2019

Conversation

@HappyTobi
Copy link
Contributor

commented Feb 13, 2019

Add new autopilot cli-plugin
Plugin will be active maintained

@cfdreddbot

This comment has been minimized.

Copy link

commented Feb 13, 2019

Hey HappyTobi!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process.

The following github user @HappyTobi is not covered by a CLA.

After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s).

@cf-gitbot

This comment has been minimized.

Copy link
Collaborator

commented Feb 13, 2019

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/163937075

The labels on this github issue will be updated when the story is started.

@jenspinney

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Hey @HappyTobi. Thanks for fixing up the failures reported by Travis. Once you sign the CLA (or publicize your membership in an organization that's has a org-wide CLA), just close and re-open the pull request to get cfdreddbot to trigger again, and we'll merge this. The comment from cfdreddbot above has a link for more info on how to sign the CLA or publicize org membership.

@cfdreddbot

This comment has been minimized.

Copy link

commented Feb 13, 2019

Hey HappyTobi! The commit authors and yourself have already signed the CLA.

@HappyTobi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

Hey @HappyTobi. Thanks for fixing up the failures reported by Travis. Once you sign the CLA (or publicize your membership in an organization that's has a org-wide CLA), just close and re-open the pull request to get cfdreddbot to trigger again, and we'll merge this. The comment from cfdreddbot above has a link for more info on how to sign the CLA or publicize org membership.

Thanks I've done that

@cloudfoundry cloudfoundry deleted a comment from cf-gitbot Feb 13, 2019

@jenspinney

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Great, thanks!

@jenspinney jenspinney merged commit 62299d2 into cloudfoundry:master Feb 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cf-gitbot cf-gitbot removed the unscheduled label Feb 13, 2019

jenspinney added a commit that referenced this pull request Feb 16, 2019

Revert "Merge pull request #282 from HappyTobi/master"
This reverts commit 62299d2, reversing
changes made to 36d6d81.
@jenspinney

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

Hi @HappyTobi,

We realized after merging this that there are now two autopilot commands. I tried to rename yours to tobi-autopilot in the YAML file to avoid confusion, but then we hit an error because your plugin binary's name needs to match the name in the YAML file.

To get around this, I reverted this merge, but we welcome you to resubmit it with a different name from the existing autopilot. Sorry for the inconvenience!

@HappyTobi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2019

@jenspinney no Problem will change that and update the pull request.

Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.