From 6e5872822c5a22a59eec44be5118f9606639c194 Mon Sep 17 00:00:00 2001 From: Sebastian Vidrio Date: Tue, 3 Apr 2018 17:27:16 -0700 Subject: [PATCH] Convert all env values to strings [finishes #154745470] Signed-off-by: Elena Sharma --- app/messages/app_manifest_message.rb | 4 ++-- spec/unit/messages/app_manifest_message_spec.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/messages/app_manifest_message.rb b/app/messages/app_manifest_message.rb index db672ccbaad..15d8e00be6b 100644 --- a/app/messages/app_manifest_message.rb +++ b/app/messages/app_manifest_message.rb @@ -96,8 +96,8 @@ def app_update_attribute_mapping def env_update_attribute_mapping mapping = {} - if requested?(:env) - mapping[:var] = env + if requested?(:env) && env.is_a?(Hash) + mapping[:var] = env.each { |k, v| env[k] = v.to_s } end mapping end diff --git a/spec/unit/messages/app_manifest_message_spec.rb b/spec/unit/messages/app_manifest_message_spec.rb index e9255feea5a..1dd03fe340f 100644 --- a/spec/unit/messages/app_manifest_message_spec.rb +++ b/spec/unit/messages/app_manifest_message_spec.rb @@ -609,7 +609,7 @@ module VCAP::CloudController message = AppManifestMessage.create_from_http_request(parsed_yaml) expect(message).to be_valid expect(message.app_update_environment_variables_message.var). - to eq({ foo: 'bar', baz: 4.44444444444, qux: false }) + to eq({ foo: 'bar', baz: '4.44444444444', qux: 'false' }) end end end