Refactor some compound conditionals on services #1172
Conversation
Hey lurraca! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/158918860 The labels on this github issue will be updated when the story is started. |
LGTM, SAPI team will merge. |
Very small refactor of some compound conditionals in /services.
Moving compound conditional into named method, with a higher level concept name
Using the safe navigator instead of nil or false check.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
master
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests