New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some compound conditionals on services #1172

Merged
merged 1 commit into from Jul 19, 2018

Conversation

Projects
None yet
6 participants
@lurraca
Member

lurraca commented Jul 9, 2018

Very small refactor of some compound conditionals in /services.

  • Moving compound conditional into named method, with a higher level concept name

  • Using the safe navigator instead of nil or false check.

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the master branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@cfdreddbot

This comment has been minimized.

cfdreddbot commented Jul 9, 2018

Hey lurraca!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

@cf-gitbot

This comment has been minimized.

Collaborator

cf-gitbot commented Jul 9, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/158918860

The labels on this github issue will be updated when the story is started.

@Samze

This comment has been minimized.

Contributor

Samze commented Jul 16, 2018

LGTM, SAPI team will merge.

@ablease ablease added the sapi label Jul 18, 2018

@georgi-lozev georgi-lozev merged commit 7e9b50f into cloudfoundry:master Jul 19, 2018

4 checks passed

codeclimate All good!
Details
codeclimate/diff-coverage 100% (80% threshold)
Details
codeclimate/total-coverage 96% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cf-gitbot cf-gitbot removed the unscheduled label Jul 19, 2018

@Samze Samze deleted the cloudfoundry-incubator:refactor-compound-conditionals branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment