New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible nested domain creation rules. #316

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@youngm
Contributor

youngm commented Nov 26, 2014

This is the PR for Issue #311.

This PR changes domain and route creation in the following ways:

  • You can now create private and shared sub domains of a shared domain
  • You can now create shared parent domains of private and shared domains
  • You can now create private sub and parent domains of private domains if all are in the same org
  • You cannot create a shared domain with a parent private domain
  • When a domain is created a check for matching routes is done
  • When a route is created a check for matching domains is done

This has some tricky logic but I believe I got all of the use cases covered in tests.

@cfdreddbot

This comment has been minimized.

cfdreddbot commented Nov 26, 2014

Hey youngm!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot

This comment has been minimized.

Collaborator

cf-gitbot commented Nov 26, 2014

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/83505974.

@youngm

This comment has been minimized.

Contributor

youngm commented Nov 26, 2014

I updated the api checksum and it didn't kick of a build. Can someone start a build for me?.

@youngm

This comment has been minimized.

Contributor

youngm commented Dec 2, 2014

Rebased to try and prompt travis to do a new build.

@jfmyers9

This comment has been minimized.

Member

jfmyers9 commented Dec 2, 2014

Merged as of 5896366.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment