Use consistent hash structure for process stats #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
force-pushed
the
consistent-stats-hash
branch
from
69effa6
to
80ca10c
Compare
The ProcessStatsPresenter distinguishes between 'down' and 'found' instances. For 'down' instances it expects the 'uptime' key in the given hash itself, for 'found' instances, it is part of the 'stats' hash. Although the ReporterMixin constructed 'down' instances as expected, there were cases (e.g. placement errors) where a different hash was created. This resulted in a JSON response containing "uptime":null. With this change a consistent hash structure is used for all cases, i.e. 'uptime' is a key in 'stats'.
philippthun
force-pushed
the
consistent-stats-hash
branch
from
80ca10c
to
1bd2e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ProcessStatsPresenterdistinguishes between down and found instances. For down instances it expects theuptimekey in the given hash itself, for found instances, it is part of thestatshash. Although theReporterMixinconstructed down instances as expected, there were cases (e.g. placement errors) where a different hash was created. This resulted in a JSON response containing"uptime":null.With this change a consistent hash structure is used for all cases, i.e.
uptimeis a key instats.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests