Exclude the newly added Readme.md file when checking applied migrations #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moleske
approved these changes
Oct 11, 2023
|
this fix is correct, but the pipeline uses what is already deployed on the bosh api vm, which is the latest cf deployment. This means it does not use the local version of cloud_controller_ng when running the task edit - though now I realize that means waiting until a release of capi to move the readme back... Maybe this pipeline should be using the under test version of cloud_controller_ng? I don't think so cause the point of the pipeline is to do backwards compatible tests, which means using the previously released capi version |
philippthun
added a commit
to cloudfoundry/capi-ci
that referenced
this pull request
Oct 12, 2023
Apply fix from ccng PR #3475 [1]. [1] cloudfoundry/cloud_controller_ng#3475
This was referenced Oct 12, 2023
geofffranks
pushed a commit
to geofffranks/cloud_controller_ng
that referenced
this pull request
Oct 19, 2023
…ns (cloudfoundry#3475) Co-authored-by: Josh Russett <jrussett@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kiki-back-compat-migrations complains with this message [1]:
[1] https://ci.capi.land/teams/main/pipelines/capi/jobs/kiki-back-compat-migrations/builds/1279
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests