Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce single source of truth for audit events #3504

Merged

Conversation

johha
Copy link
Contributor

@johha johha commented Nov 3, 2023

Audit events are generated in multiple modules and classes within ccng. This makes it difficult to get an overview of the available audit events.
This refactoring introduces a new event_types class which contains all audit events. This can be used e.g. to update the docs.

Related docs PR: cloudfoundry/docs-running-cf#115

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@johha johha force-pushed the audit-events-refactor branch 4 times, most recently from c877e6b to 7c99761 Compare November 6, 2023 14:59
@johha johha marked this pull request as ready for review November 6, 2023 15:00
Audit events are generated in multiple modules and classes within ccng.
This makes it difficult to get an overview of the available audit
events.
This refactoring introduces a new event_types class which contains all
audit events. This allows to list all types in the docs.
johha added a commit to johha/docs-running-cf that referenced this pull request Nov 7, 2023
Some audit events created in cloud controller are missing in this documentation. 
Related ccng PR: cloudfoundry/cloud_controller_ng#3504
@FloThinksPi FloThinksPi merged commit 22569e9 into cloudfoundry:main Nov 7, 2023
7 checks passed
@FloThinksPi FloThinksPi deleted the audit-events-refactor branch November 7, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants