Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect DB_CONNECTION_STRING in integration tests #673

Conversation

nota-ja
Copy link
Contributor

@nota-ja nota-ja commented Sep 1, 2016

  • A short explanation of the proposed change:
    The current implementation of the integration tests ignores DB_CONNECTION_STRING,
    so the tests fail if the database setting is different to the default.
    It will be more convenient to respect DB_CONNECTION_STRING in the integration tests.
  • An explanation of the use cases your change solves
    • When running the integration tests with a database having setttings other than the default, you will not get errors
    • When running all the tests with a database having setttings other than the default, you can run them at one time without errors
  • I have viewed signed and have submitted the Contributor License Agreement
  • I have made this pull request to the master branch
  • I have run all the unit tests using bundle exec rake
  • I have run CF Acceptance Tests on bosh lite

The current implementation of the integration tests ignores `DB_CONNECTION_STRING`,
so the tests fail if the database setting is different to the default.
It will be more convenient to respect `DB_CONNECTION_STRING` in the integration tests.
@cfdreddbot
Copy link

Hey nota-ja!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/129608081

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants