Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credhub Import Ignores Parse Errors #99

Open
1 of 3 tasks
Salamandastron1 opened this issue Jun 18, 2020 · 1 comment
Open
1 of 3 tasks

Credhub Import Ignores Parse Errors #99

Salamandastron1 opened this issue Jun 18, 2020 · 1 comment

Comments

@Salamandastron1
Copy link

Salamandastron1 commented Jun 18, 2020

What version of the credhub server you are using?
Server Version: 2.5.7

What version of the credhub cli you are using?
CLI Version: 2.7.0

If you were attempting to accomplish a task, what was it you were attempting to do?
I was attempting to import nested certificate variables. Cert, and Private key (PEM)

What did you expect to happen?
I expected the credentials to be uploaded and if there is a value in yaml file that has incorrect indentation then I should be notified.

What was the actual behavior?
The cli fails silently on parse errors and uploads all other credentials

Please confirm where necessary:

  • I have included a log output
  • My log includes an error message
  • I have included steps for reproduction

Steps to reproduce:

credhub import -f secret-bad-indent.yml 
secret-bad-indent.yml 
credentials:
  - name: /concourse/np/poe-ssl-pem
    type: certificate
    value:
      certificate: |
        -----BEGIN CERTIFICATE-----
        
        -----END CERTIFICATE-----
    private_key: |
      -----BEGIN RSA PRIVATE KEY-----
      
      -----END RSA PRIVATE KEY-----
credhub import -f secret-good.yml 
secret-good.yml 
credentials:
  - name: /concourse/np/poe-ssl-pem
    type: certificate
    value:
      certificate: |
        -----BEGIN CERTIFICATE-----
        
        -----END CERTIFICATE-----
      private_key: |
        -----BEGIN RSA PRIVATE KEY-----
        
        -----END RSA PRIVATE KEY-----

If you are a PCF customer with an Operation Manager (PCF Ops Manager) please direct your questions to support (https://support.pivotal.io/)

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/173401404

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants