Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Escape env values rather than simply quote them. #153

Closed
wants to merge 1 commit into from

Conversation

mheath
Copy link
Contributor

@mheath mheath commented Sep 23, 2014

This implements a fix for #144.

@cfdreddbot
Copy link

Hey mheath!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/79406518.

@emalm
Copy link
Contributor

emalm commented Sep 24, 2014

Hi, @mheath,

Thanks for the PR. We are concerned about this change potentially altering behavior around expansion of the user-provided environment variables. The WIP commit 9dfa3c3 does limit the escaping to only the system-provided variables, so it seems like it would address your problems with the evaluation of the VCAP_SERVICES credential values. You'd be welcome to submit a new PR by adding (a potentially a small amount of) changes to the work that @julz and @fraenkel started in that branch.

Best,
@ematpl && @stupakov, for the CF Runtime team

luan added a commit that referenced this pull request Feb 10, 2015
@crhino
Copy link
Contributor

crhino commented May 1, 2015

Closing this as the issue has been fixed in commit above.

@crhino crhino closed this May 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants