Ignore EntryNotFound and AlreadyClosed errors when cleaning up cache #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cache entry not found when cleaning up cache after container is deleted we can ignore this error
ameowlia
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide the following information:
What is this change about?
After container is deleted Rep cleans up the cache If cleaning up cache fails, we retry deleting container. If cleaning up cache fails because cache entry is not found Rep gets stuck in cleaning up containers and drain never exits. Cleaning up cache should be successful if cache entry is not found.
How should this change be described in diego-release release notes?
Cache cleanup after container deletion does not fail if cache entry is not found.
Please provide any contextual information.
Original issue in slack
Tag your pair, your PM, and/or team!
Thank you!