Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] NewWithPasswordCredentials/NewWithClientCredentials return wrapper struct with .Token() #4

Closed
wants to merge 1 commit into from

Conversation

drnic
Copy link
Contributor

@drnic drnic commented Jul 1, 2018

See example: https://github.com/starkandwayne/ultimate-guide-to-uaa-examples/blob/e8ca806baadb7907a91ca32ade13246c61bbdcbc/golang/resource-server-cli/src/resource-server-cli/main.go#L54-L66

With consideration to #5 proposal to change API#AuthenticatedClient into a function, perhaps API can become an interface with AuthenticatedClient rather than a struct; and the returned struct from NewWithXYZ can hold the xyz.Config and have its own AuthenticatedClient functions etc.

@drnic drnic changed the title NewWithPasswordCredentials/NewWithClientCredentials return wrapper struct with .Token() [WIP] NewWithPasswordCredentials/NewWithClientCredentials return wrapper struct with .Token() Jul 1, 2018
@jghiloni
Copy link

jghiloni commented Jul 2, 2018

I see no problems with this but I'll wait for @joefitzgerald to get back from his vacation to look at it, as he's been working with the UAA team on this and may have to take this into account.

@joefitzgerald
Copy link
Contributor

This is fixed in v0.2.0, which includes a uaa.API.Token function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants