dev-test: use one $GOPATH instead of Godeps #2

Merged
merged 1 commit into from Mar 9, 2014

Projects

None yet

2 participants

Member
vito commented Mar 9, 2014

This is more convenient for development when you're working on/adding
debugging to a libary and just want to run Inigo.

Also, rsync most code in parallel.

Contributor
onsi commented Mar 9, 2014

What if we don't use a randomly generated temp directory but just /tmp/inigo and rely on rsync to mirror into it? Could speed up subsequent copy steps, no?

On Mar 8, 2014, at 5:09 PM, Alex Suraci notifications@github.com wrote:

This is more convenient for development when you're working on/adding
debugging to a libary and just want to run Inigo.

Also, rsync most code in parallel.

You can merge this Pull Request by running

git pull https://github.com/cloudfoundry-incubator/inigo better-dev-test
Or view, comment on, or merge it at:

#2

Commit Summary

dev-test: use one $GOPATH instead of Godeps
File Changes

M scripts/dev-test (31)
M scripts/dev-test-inner (18)
Patch Links:

https://github.com/cloudfoundry-incubator/inigo/pull/2.patch
https://github.com/cloudfoundry-incubator/inigo/pull/2.diff

Reply to this email directly or view it on GitHub.

@vito vito dev-test: use one $GOPATH instead of Godeps
This is more convenient for development when you're working on/adding
debugging to a libary and just want to run Inigo.

Also, rsync most code in parallel.
6159804
Member
vito commented Mar 9, 2014

yep; shaves ~2 seconds off startup (now just 1.2 seconds on my MBA). updated.

Contributor
onsi commented Mar 9, 2014

saweet :D

On Sat, Mar 8, 2014 at 6:31 PM, Alex Suraci notifications@github.comwrote:

yep; shaves ~2 seconds off startup (now just 1.2 seconds on my MBA).
updated.

Reply to this email directly or view it on GitHubhttps://github.com/cloudfoundry-incubator/inigo/pull/2#issuecomment-37117137
.

Contributor
onsi commented Mar 9, 2014

lgtm - I'm assuming the godep save addition isn't particularly slow?

@onsi onsi merged commit 9c184ae into master Mar 9, 2014
Member
vito commented Mar 9, 2014

yeah; it's the slowest bit since I couldn't easily parallelize it, but it guarantees we pull in only the dependencies our components need, which is awesome. (otherwise we'd have to rsync the entire gopath.)

Contributor
onsi commented Mar 9, 2014

Yep, and then copy it into the container which would take a long time... (I'm looking at you, code.google.com/p/go)

On Mar 8, 2014, at 6:48 PM, Alex Suraci notifications@github.com wrote:

yeah; it's the slowest bit since I couldn't easily parallelize it, but it guarantees we pull in only the dependencies our components need, which is awesome. (otherwise we'd have to rsync the entire gopath.)


Reply to this email directly or view it on GitHub.

@vito vito deleted the better-dev-test branch Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment