Migrate from RestTemplate to WebClient#956
Conversation
| import reactor.core.publisher.Mono; | ||
|
|
||
| class TaggingRequestInterceptor implements ClientHttpRequestInterceptor { | ||
| class TaggingRequestFilter implements ExchangeFilterFunction { |
There was a problem hiding this comment.
Probably rename it to TaggingRequestFilterFunction to be suitable with the interface name
| public void testInjectGenericValue() throws IOException { | ||
| TaggingRequestFilter testedFilter = new TaggingRequestFilter("1.58.0"); | ||
| testedFilter.filter(clientRequest, nextFilter); | ||
| assertNotNull(clientRequest.headers()); |
There was a problem hiding this comment.
You can assign clientRequest.headers() to local field called "actualHeaders" and use it afterwads.
| assertTrue(clientRequest.headers() | ||
| .containsKey(TaggingRequestFilter.TAG_HEADER_NAME)); | ||
| String expectedValue = "MTA deploy-service v1.58.0"; | ||
| Optional<String> foundValue = clientRequest.headers() |
There was a problem hiding this comment.
You can simplify by using assertEquals(expectedValue, actualHeaders.getFirst(TaggingRequestFilter.TAG_HEADER_NAME))
| } | ||
|
|
||
| @Test | ||
| public void testGetHeaderValue() { |
There was a problem hiding this comment.
I think this unit test is not needed because it is already covered.
| <!-- C3P0 is only used if Quartz needs to create its own DataSource. Since we use Spring for that purpose, | ||
| it is not required. --> | ||
| <!-- C3P0 is only used if Quartz needs to create its | ||
| own DataSource. Since we use Spring for that purpose, it is not required. --> |
There was a problem hiding this comment.
Are these formatting changes needed?
| } | ||
|
|
||
| @Test | ||
| public void testInjectOrgAndSpaceValues() throws IOException { |
There was a problem hiding this comment.
Why so many unit tests? I think that some of them tests the same thing.
You can prepare one larger unit tests that tests every tag, other option is to have 3 different unit tests for each tag
Boris-ILIEV
force-pushed
the
web-client
branch
from
e2029e5 to
da605e6
Compare
|
|
||
| @Override | ||
| public void registerRestLogListener(RestLogCallback callBack) { | ||
| executeWithRetry(() -> delegate.registerRestLogListener(callBack)); |
There was a problem hiding this comment.
This was executed with retry... xD /facepalm
| requires spring.security.jwt; | ||
| requires spring.web; | ||
| requires spring.webflux; | ||
| requires reactor.core; |
There was a problem hiding this comment.
Order these alphabetically for easier navigation.
Boris-ILIEV
force-pushed
the
web-client
branch
from
da605e6 to
ef49396
Compare
3 participants
ISSUE: LMCROSSITXSADEPLOY-1476