New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Yarn (use Yarn package manager instead of npm when `yarn.lock` file detected) #71

Closed
wants to merge 4 commits into
base: develop
from

Conversation

Projects
None yet
4 participants
@kauffecup

kauffecup commented Nov 9, 2016

Yarn is a new package manager developed by Facebook, more info here: https://yarnpkg.com/ It is both faster than npm install and more reliable and deterministic. It uses a a detailed but concise lockfile to guarantee that the same install works the exact same way on different systems (npm installs can have race conditions on full package installs that can result in pretty nasty bugs and differences from machine to machine).

This change is based off of the work (unmerged) in https://github.com/heroku/heroku-buildpack-nodejs/tree/yarn

It will download and use yarn for installs and rebuilds if the yarn.lock file is detected, otherwise it is assumed that the user does not want to use yarn and the buildpack functions works as before and uses npm.

  • I have viewed signed and have submitted the Contributor License Agreement
@cfdreddbot

This comment has been minimized.

Show comment
Hide comment
@cfdreddbot

cfdreddbot Nov 9, 2016

Hey kauffecup!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cfdreddbot commented Nov 9, 2016

Hey kauffecup!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot

This comment has been minimized.

Show comment
Hide comment
@cf-gitbot

cf-gitbot Nov 9, 2016

Collaborator

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/134044611

The labels on this github issue will be updated when the story is started.

Collaborator

cf-gitbot commented Nov 9, 2016

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/134044611

The labels on this github issue will be updated when the story is started.

@RochesterinNYC

This comment has been minimized.

Show comment
Hide comment
@RochesterinNYC

RochesterinNYC Nov 10, 2016

Contributor

Thanks for this PR @kauffecup ! I think we'll wait to pull those changes from the upstream when it lands. We usually prefer taking from upstream via merges.

Contributor

RochesterinNYC commented Nov 10, 2016

Thanks for this PR @kauffecup ! I think we'll wait to pull those changes from the upstream when it lands. We usually prefer taking from upstream via merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment