Enable SSL on PostgreSQL server #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey valeriap! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/147577385 The labels on this github issue will be updated when the story is started. |
suhlig
reviewed
Jun 21, 2017
| func createDeployment(postgresReleaseVersion int, manifestPath string, prefix string) error { | ||
| name := helpers.GenerateEnvName(prefix) | ||
| return updateDeployment(postgresReleaseVersion, manifestPath, name) | ||
| } | ||
| func updateDeployment(postgresReleaseVersion int, manifestPath string, name string) error { |
There was a problem hiding this comment.
Can we call this CreateOrUpdateDeployment to express the actual functionality?
suhlig
suggested changes
Jun 21, 2017
- Remove references to tag property in databases and roles - Provide script for generating SSL certificates [#146008833] Signed-off-by: Steffen Uhlig <Steffen.Uhlig@de.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
databases.tls.certificatedatabases.tls.private_keytlssection is specified in the postgres job properties, PostgreSQL is started with SSL enabled.generate-postgres-certsis provided that creates a CA, generates a keypair, and signs it with the CA.use_ssl.ymlis also provided to show how use BOSH variables to generate the certificates.spechas been improved to provide examples for array of hashes propertiestagproperty have been removed from templates