Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
running_in_container function in gorouter_ctl does not work properly #138
Thanks for submitting an issue to
While gorouter_ctl is initiated/started, gorouter_ctl does not configure the /proc/sys/net/ipv4 parameters.
Performing stemcell version upgrade on platform.
Current using Stemcell Version: Ubuntu Trusty v3586.60
Steps to Reproduce
With latest stemcell version v170.25,
With previous stemcell version v3586.60
After updating the Ubuntu Xenial stemcell, running_container function always returns that process is running inside a container.
We have created an issue in Pivotal Tracker to manage this:
The labels on this github issue will be updated when the story is started.
Couple of notes:
@emalm, good point. Though this approach still sounds quite error-prone. Multiple jobs may potentially change same parameters. Also some jobs change kernel parameters in ctl script instead of pre-start which leads to race condition with other jobs. Wouldn't it be feasible to define kernel settings per instance group using os-conf-release in cf-deployment?
Yeah, in general I think that the adjustment of kernel parameters in a BOSH deployment should be done on a per-instance-group basis because of the VM-wide effects, likely explicitly in the deployment manifest, and the os-conf-release overall can do that.
Even then, there are some subtleties: for example, https://github.com/cloudfoundry/diego-release/blob/v2.28.0/jobs/rep/templates/set-rep-kernel-params.erb#L21 sets
Those modules should be loaded explicitly then. Another way of doing this could be a job (may be a feature to os-conf-release) which would scan
It feels like we are reinventing yet another init system btw.