Conversation
sean-sq-chen
changed the title
| "test": "karma start karma.conf.js --single-run", | ||
| "update-webdriver": "webdriver-manager update" | ||
| "update-webdriver": "webdriver-manager update", | ||
| "watch": "node_modules/.bin/gulp watch" |
There was a problem hiding this comment.
You can shorten this to just: gulp watch
|
Can you add this footer to the login page as well? |
| @@ -0,0 +1,53 @@ | |||
| page-footer { | |||
Also moving up the folder for page-footer one level because the directive is used in login page as well.
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
recheck |
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
This is what the footer looks like on the login page, with the browser full-screen, on my Macbook. (1280px width for the document body)
|
|
@tara-gibbs yes, that is the spec of the design we got. There is not responsive layout solution provided. The font looks really huge and takes a lot of space. But it is not an implementation issue. We should bring this to UX. Btw, why there is no image and the font weight is not correctly showing on your screenshot? Have you updated your local helion-ui-theme repo? you need to update it and re-provision your UI environment to get the latest theming. |
|
@sean-sq-chen The description for this PR has one TODO. Is this ready for merge or will you still be updating with the |
|
@ongk it is for CRers information. I think the PR is ready to merge. |
|
+1 LGTM. Yeah, I think we'll need to chat with UX about responsiveness of that footer. Can you email Cierra about it? |
|
@ongk My email still not working. I'll add a simple responsive layout solution and ask UX if they like it or not. |
|
@ongk @tara-gibbs A simple responsive layout solution has been added. |
|
We'll need to make sure that the responsive footer works at the minimum width before the breakpoint as well. Right now the text and images are overlapping at that width.
|
|
@ongk @tara-gibbs now using 16px font. it looks better. This is a temporary responsive solution. A final responsive solution should come from UX. We can treat is as another ticket once the solution provided. |
Don't log DB username password
Refactor ApplicationBaseComponent
5 participants
@ongk @tara-gibbs @randyochoa @domvieira