Feature/135 style apps card#152
Conversation
|
From Jenkins: There was a test failure while running Jenkins tests. |
| <strong>Allocated Disk Space</strong>: {{applicationGalleryCardCtrl.app.entity.disk_quota}} MB | ||
| <br/> | ||
| <strong>App Instances</strong>: {{applicationGalleryCardCtrl.app.entity.instances}} | ||
| <table style="width: 100%;" class="ng-scope"> |
There was a problem hiding this comment.
@mwhagedorn You can use add class='table' and remove the style attribute, I believe.
There was a problem hiding this comment.
You can use a description list instead of table here: see example in helion-ui-theme
| @@ -1,7 +1,25 @@ | |||
| // cloud-foundry.scss | |||
There was a problem hiding this comment.
The uppercasing and etc is needed to match the comp.
| line-height: $hpe-unit-space * 3; | ||
| vertical-align: middle; | ||
| margin-top: $hpe-unit-space; | ||
| height: $hpe-unit-space * 3; |
There was a problem hiding this comment.
Any reason the indent was modified here?
There was a problem hiding this comment.
no.. probably the stupid editor pycharm provides
|
+1 LGTM |
|
+1 LGTM, assuming the checks complete successfully. |
|
From Jenkins: There was a test failure while running Jenkins tests. |
5 similar comments
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
From Jenkins: There was a test failure while running Jenkins tests. |
Relay underlying message from internal method
4 participants
Style Applications Gallery Card to match comps. Missing some usage data as unable to determine if we can get that from the API. Also missing a yellow/green 'progress bar' type display for the same reason (not sure we can get used vs allocated)