WIP - TEAMFOUR-154 No registered clusters#165
Conversation
If no registered clusters are available, the user should see a message-box with a button to add clusters. Also, a button to add clusters should appear in the header of the table of clusters. Per Sean's suggestion, I separated some things out into separate directives.
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
I believe the story was for ITOps and not the |
- Unsure if this is best way to fix. Opening PR to get feedback.
- This PR is dependent on changes to stratos-node-server:
https://github.com/hpcloud/stratos-node-server/pull/31
|
@ongk I went ahead and rebased (apparently necessary???) and fixed the linting errors. I'm not sure what you need from me regarding the ITOps vs the Dev user. I'll go review your patches and ask you in a bit. :-) |
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
From Jenkins: There was a test failure while running Jenkins tests. |
My previous patches added service registration for normal users, instead of admin users. That was wrong, and Kelly has helped me figure out what I need to do to move that functionality over to admin users.
woodm1979
changed the title
|
From Jenkins: There was a test failure while running Jenkins tests. |
On the register-clusters page, you can now remove clusters, and the complete button works correctly. Also removed some debug code that was there previously as scaffolding.
|
From Jenkins: There was a test failure while running Jenkins tests. |
| * @public | ||
| */ | ||
| disconnect: function (serviceInstanceUrl) { | ||
| remove: function (id) { |
There was a problem hiding this comment.
This was only use id as parameter to follow the service instance API; however, if it's easier to pass in the cluster object, I think that is ok as well. The id can always be retrieved from the object and it will simplify the _remove below.
The karma tests were failing because I had really just copied them from the service-registration code. Many of them didn't apply, and a bit of correcting was absolutely necessary. Also, per Kelly's suggestions: removed the hideClusterRegistration method converted app.model.serviceInstance.remove to accept a serviceInstance instead of an id.
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
There's something wrong with this PR/branch. I'm closing this. Use #178 instead. |
4 participants
If no registered clusters are available, the user should see a
message-box with a button to add clusters.
Also, a button to add clusters should appear in the header of the table
of clusters.
Per Sean's suggestion, I separated some things out into separate
directives.