Skip to content

TEAMFOUR-148 Add unit tests for services model#170

Merged
ongk merged 1 commit into
masterfrom
teamfour-148-service-model-unit-tests
Apr 6, 2016
Merged

TEAMFOUR-148 Add unit tests for services model#170
ongk merged 1 commit into
masterfrom
teamfour-148-service-model-unit-tests

Conversation

@ankurhpe
Copy link
Copy Markdown
Contributor

@ankurhpe ankurhpe commented Apr 5, 2016

WIP: Currently, model manager in new services.model.spec.js file fails to successfully retrieve instance of cloud-foundry.model.service class.

@WAT-TeamFour
Copy link
Copy Markdown

From Jenkins: There was a test failure while running Jenkins tests.

Comment thread tools/karma.conf.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this back down to below line 37 - so it's grouped together. Looks like order doesn't matter in this case.

@ankurhpe ankurhpe force-pushed the teamfour-148-service-model-unit-tests branch from bac16b4 to 3a4515c Compare April 5, 2016 23:45
@WAT-TeamFour
Copy link
Copy Markdown

From Jenkins: There was a test failure while running Jenkins tests.

1 similar comment
@WAT-TeamFour
Copy link
Copy Markdown

From Jenkins: There was a test failure while running Jenkins tests.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These keys need the double quotes removed as well - linter errors. Not sure if it's complaining about mixing double and single quotes too. Maybe just change all double quotes to single quotes just to be safe.

@ankurhpe ankurhpe force-pushed the teamfour-148-service-model-unit-tests branch from fceda0e to 82145b8 Compare April 6, 2016 01:55
@WAT-TeamFour
Copy link
Copy Markdown

From Jenkins: There was a test failure while running Jenkins tests.

1 similar comment
@WAT-TeamFour
Copy link
Copy Markdown

From Jenkins: There was a test failure while running Jenkins tests.

@ankurhpe ankurhpe force-pushed the teamfour-148-service-model-unit-tests branch from 82145b8 to 4bd466f Compare April 6, 2016 02:15
@WAT-TeamFour
Copy link
Copy Markdown

From Jenkins: There was a test failure while running Jenkins tests.

@ongk
Copy link
Copy Markdown
Contributor

ongk commented Apr 6, 2016

recheck

@ongk ongk merged commit a4254d7 into master Apr 6, 2016
@ongk ongk deleted the teamfour-148-service-model-unit-tests branch April 6, 2016 17:21
irfanhabib added a commit that referenced this pull request Jun 1, 2017
Add extra metadata to the stackatoinfo call for Cloud Foundry
richard-cox pushed a commit that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants