TEAMFOUR-144 - Implement the states and notifications#171
Merged
Conversation
…-ui into app-details-notification * 'app-details-notification' of github.com:hpcloud/stratos-ui: Implementing app lifecycle notification # Conflicts: # src/plugins/cloud-foundry/cloud-foundry.scss # src/plugins/cloud-foundry/view/applications/application/application.html
|
From Jenkins: There was a test failure while running Jenkins tests. |
sean-sq-chen
changed the title
| <span class="btn-group"> | ||
| <button class="btn btn-default btn-info" | ||
| translate | ||
| ng-disabled="appCtrl.model.appStateSwitchTo==='PENDING'" |
Contributor
There was a problem hiding this comment.
I may not be familiar with the states yet, but should the user be able to restart a stopped app?
Contributor
Author
There was a problem hiding this comment.
It should be "appCtrl.model.application.summary.state==='PENDING'"
When a request to change the application's state has been sent to server, the state of the app on client side is PENDING, during this time, all the buttons should be disabled until a response has been received.
Contributor
|
+1 LGTM |
richard-cox
added a commit
that referenced
this pull request
Jan 17, 2020
Allow database path to be set - support persistent DB with AIO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.hpcloud.net/browse/TEAMFOUR-144
This PR includes:
Not included:
@ongk @tara-gibbs