WIP: TEAMFOUR-113-initial cut at styling service detail#172
WIP: TEAMFOUR-113-initial cut at styling service detail#172mwhagedorn wants to merge 19 commits into
Conversation
Update developer service instance registration
|
From Jenkins: There was a test failure while running Jenkins tests. |
| } | ||
| ]; | ||
| this.showServiceDetail = function(service) { | ||
| this.currentService = service; |
|
Can you also update the PR title to include the JIRA ticket number? We've been doing something like: TEAMFOUR-123 - [Short PR description]. Thanks. |
|
From Jenkins: There was a test failure while running Jenkins tests. |
mwhagedorn
changed the title
|
From Jenkins: There was a test failure while running Jenkins tests. |
|
From Jenkins: There was a test failure while running Jenkins tests. |
| } | ||
|
|
||
| ApplicationServiceDetailController.$inject = [ | ||
| '$state' |
There was a problem hiding this comment.
I don't think you need $state here
There was a problem hiding this comment.
I wont but the person who does 'add' will...
…tests TEAMFOUR-148 Add unit tests for services model
|
From Jenkins: There was a test failure while running Jenkins tests. |
| @@ -0,0 +1,37 @@ | |||
| (function () { | |||
There was a problem hiding this comment.
This file should be:
/cloud-foundry/view/applications/application/services/service/service.directive.js
| </p> | ||
| </div> | ||
| <div class="row"> | ||
| {{ ::applicationServiceDetailCtrl.service.entity.description }}. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum |
There was a problem hiding this comment.
Remove extra whitespace.
|
From Jenkins: There was a test failure while running Jenkins tests. |
| } | ||
|
|
||
| angular.extend(ApplicationServiceDetailController.prototype, { | ||
| close: function() { |
There was a problem hiding this comment.
Format: missing whitespace after function.
|
This directive shouldn't define controller with it. There is not logic for itself. All it does is passing in parent controller and parent controller's properties and call methods on the parent. We can remove the controller and remove all the bindings and the isolated scope. code will be simplified a lot. |
|
superceded by https://github.com/hpcloud/stratos-ui/pull/175 |
Added trackby to tables and card views
4 participants
superceded by #175