Skip to content

Added Gulp config files for paths#27

Merged
sean-sq-chen merged 2 commits into
masterfrom
add-gulp-config
Jan 15, 2016
Merged

Added Gulp config files for paths#27
sean-sq-chen merged 2 commits into
masterfrom
add-gulp-config

Conversation

@ongk
Copy link
Copy Markdown
Contributor

@ongk ongk commented Jan 15, 2016

Moved out the paths into a separate config file for a cleaner gulpfile of just tasks

Comment thread tools/gulpfile.js
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is great!

can we create aliases for path, jsSourceFiles, etc. so that we have a little bit more cleaner code? for example:

var path = config.path
, jsSourceFiles = config.jsSourceFiles
, jsLibs = config. jsLibs
...
This way we don't need to make changes in tasks.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

sean-sq-chen added a commit that referenced this pull request Jan 15, 2016
Added Gulp config files for paths
@sean-sq-chen sean-sq-chen merged commit 0fe6ce9 into master Jan 15, 2016
@ongk ongk deleted the add-gulp-config branch January 15, 2016 21:06
irfanhabib pushed a commit that referenced this pull request Jun 1, 2017
temporary fix to allow console to proxy calls with no auth until HCE …
irfanhabib pushed a commit that referenced this pull request Jun 6, 2017
Fixed typo in deploy_to_local.sh
irfanhabib pushed a commit that referenced this pull request Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants