From d6e10f9291db54fb960f1d903fc2635730acd25b Mon Sep 17 00:00:00 2001 From: Carson Long Date: Mon, 2 Oct 2023 13:47:49 -0700 Subject: [PATCH] fix(pkg/egress/stats): resolve failing tests due to altered string representation of variable labels --- src/pkg/egress/stats/prom_registry_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/pkg/egress/stats/prom_registry_test.go b/src/pkg/egress/stats/prom_registry_test.go index a69ab4ad..a8d63e47 100644 --- a/src/pkg/egress/stats/prom_registry_test.go +++ b/src/pkg/egress/stats/prom_registry_test.go @@ -20,30 +20,30 @@ var _ = Describe("Prometheus Registry", func() { It("registers the gauge when it's first gotten", func() { gauge := toPromGauge(registry.Get("metric_name", "origin", "unit", nil)) - Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: []}`)) + Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: {}}`)) var registered prometheus.Gauge Eventually(registerer.gauges).Should(Receive(®istered)) - Expect(registered.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: []}`)) + Expect(registered.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: {}}`)) }) It("doesn't reregister gauges", func() { gauge := toPromGauge(registry.Get("metric_name", "origin", "unit", nil)) - Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: []}`)) + Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: {}}`)) gauge = toPromGauge(registry.Get("metric_name", "origin", "unit", nil)) - Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: []}`)) + Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: {}}`)) Expect(registerer.gauges).To(HaveLen(1)) }) It("gauges with different tags are different gauges", func() { gauge := toPromGauge(registry.Get("metric_name", "origin", "unit", map[string]string{"foo": "bar2"})) - Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {foo="bar2",unit="unit"}, variableLabels: []}`)) + Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {foo="bar2",unit="unit"}, variableLabels: {}}`)) gauge = toPromGauge(registry.Get("metric_name", "origin", "unit", map[string]string{"foo": "bar"})) - Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {foo="bar",unit="unit"}, variableLabels: []}`)) + Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {foo="bar",unit="unit"}, variableLabels: {}}`)) Expect(registerer.gauges).To(HaveLen(2)) })