Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify use of multiple URLs in uaa.ldap.url #810

Merged
merged 1 commit into from Feb 29, 2024

Conversation

peterhaochen47
Copy link
Member

  • clarify that the option to put multiple URLs in uaa.ldap.url is for failover purpose only (the
    URLs beyond the first one are the backups if
    the first URL fails).
  • The previous language could mislead operators into thinking that multiple distinct LDAP servers
    can be configured at the same time via uaa.ldap.url.
  • details: UAA passes through the configured value to spring-security-ldap library, which then uses the extra URLs for failover purpose.

[#185846888]

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187121521

The labels on this github issue will be updated when the story is started.

@peterhaochen47 peterhaochen47 requested a review from a team February 27, 2024 02:14
Copy link
Contributor

@Tallicia Tallicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterhaochen47 peterhaochen47 force-pushed the pr/develop/fix-doc-ldap-url branch 2 times, most recently from 24dd8b6 to bd8a57e Compare February 29, 2024 19:18
- clarify that the option to put multiple URLs
in uaa.ldap.url is for failover purpose only (the
URLs beyond the first one are the backups if
the first URL fails).
- The previous language could mislead operators
into thinking that multiple distinct LDAP servers
can be configured at the same time via uaa.ldap.url.
- details: UAA [passes through](https://github.com/cloudfoundry/uaa/blob/05dc2c0d9903bece514fd1308f03c34792205faf/server/src/main/java/org/cloudfoundry/identity/uaa/impl/config/LdapSimpleBindConfig.java#L41)
the configured value to spring-security-ldap library,
which then [uses the extra URLs for failover purpose](https://github.com/spring-projects/spring-security/blob/48c8532a21d0aab17eac400ec3540b01249b5962/ldap/src/main/java/org/springframework/security/ldap/DefaultSpringSecurityContextSource.java#L60).

[#185846888]
@peterhaochen47 peterhaochen47 merged commit faf9ec0 into develop Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants