Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "remove: gomega github ignore removed" #811

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

hsinn0
Copy link
Contributor

@hsinn0 hsinn0 commented Feb 27, 2024

  • We still cannot bump gomega to 1.31.
  • Previous commit to remove the bump-ignore should not have been made.

This reverts commit aa1f856.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187127178

The labels on this github issue will be updated when the story is started.

@hsinn0 hsinn0 changed the base branch from develop to 74.5.x February 27, 2024 21:02
@hsinn0 hsinn0 changed the base branch from 74.5.x to develop February 27, 2024 21:03
Copy link
Contributor

@bruce-ricard bruce-ricard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was already reverted. LGTM.

- We still cannot bump gomega to 1.31.
- Previous commit to remove the bump-ignore should not have been made.

This reverts commit aa1f856.
@hsinn0 hsinn0 merged commit 99ce699 into develop Mar 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants