Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude unsupported response types in exception #2329

Merged
merged 2 commits into from
May 22, 2023

Conversation

mikeroda
Copy link
Contributor

@mikeroda mikeroda commented May 17, 2023

Change-Id: Id93034bc69355fcf988c56827fa65c70338694cf

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/185203277

The labels on this github issue will be updated when the story is started.

- avoid logging or echoing unsantized input from the request
- this mirrors the change made to AuthorizationEndpoint in
spring-security-oauth2 2.5.2.RELEASE, see:
spring-attic/spring-security-oauth@2b58aaf

Change-Id: Id93034bc69355fcf988c56827fa65c70338694cf
- apparently the whitespace is being trimmed off by spring in the xml
so the request matcher isn't doing a case insensitive comparison when
the header value is Bearer

Change-Id: I0f93cc2a0ebf364560687c4e57887a100753dd2d
@mikeroda mikeroda changed the title fix: include only supported response types in exception fix: exclude unsupported response types in exception May 17, 2023
Copy link
Member

@strehle strehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@strehle strehle merged commit 89523fb into cloudfoundry:develop May 22, 2023
@cf-gitbot cf-gitbot added delivered accepted Accepted the issue and removed delivered labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted the issue
Projects
Development

Successfully merging this pull request may close these issues.

3 participants