Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Become resilient to npm packages that install symlinks in .bin #36

Closed
davidascher opened this Issue · 1 comment

3 participants

David Ascher Karl Miki Yarkoni
David Ascher

There are lots of popular nodejs modules (e.g. express, less, jade) that install symlinks in node_modules/.bin that point back to the bin subdirectory in their respective subtree.

Currently vmc update complains about them due to a failure in understanding the symlink structure:

Error: Can't deploy application containing links '/Users/davida/src/foo/node_modules/.bin/jade' that reach outside its root '/Users/davida/src/foo'

I suspect the root bug is the fact that the symlink is assessed to reach outside its root, even though it clearly isn't:

root: /Users/davida/src/foo
link: /Users/davida/src/foo/node_modules/.bin/jade

Karl

Thanks. I had this same problem, trying to follow the instructions in the tutorial (link below), which being from 9 months ago, used npm bundle. The vmc I downloaded today did not have the fix yet.

http://support.cloudfoundry.com/entries/505133-deploying-a-node-js-app-with-npm-dependencies

Miki Yarkoni myarkoni closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.