From aabb78aaeffd095457258e30220b79e81ebecd0f Mon Sep 17 00:00:00 2001
From: Gerardo Rodriguez <mr.gerardo.rodriguez@gmail.com>
Date: Tue, 26 Jul 2022 16:45:39 -0700
Subject: [PATCH 1/4] Use aria-hidden for Pagination component ellipsis

---
 src/components/pagination/pagination.twig | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/components/pagination/pagination.twig b/src/components/pagination/pagination.twig
index 38ed1b46d..c94073df3 100644
--- a/src/components/pagination/pagination.twig
+++ b/src/components/pagination/pagination.twig
@@ -28,7 +28,12 @@
           </a>
         {% else %}
           {# Fallback for non-link pages like ellipsis gaps for first/last pages #}
-          <span class="c-pagination__action">
+          <span
+            class="c-pagination__action"
+            {% if page.title == '&hellip;' or page.title == '…' %}
+              aria-hidden="true"
+            {% endif %}
+          >
             {{ page.title }}
           </span>
         {% endif %}

From 79fdd27d56199ccd0ee522c526a54876f6b43604 Mon Sep 17 00:00:00 2001
From: Gerardo Rodriguez <mr.gerardo.rodriguez@gmail.com>
Date: Tue, 26 Jul 2022 16:50:39 -0700
Subject: [PATCH 2/4] Add changeset

---
 .changeset/spotty-owls-pay.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/spotty-owls-pay.md

diff --git a/.changeset/spotty-owls-pay.md b/.changeset/spotty-owls-pay.md
new file mode 100644
index 000000000..206646edd
--- /dev/null
+++ b/.changeset/spotty-owls-pay.md
@@ -0,0 +1,5 @@
+---
+'@cloudfour/patterns': minor
+---
+
+Add aria-hidden to Pagination component ellipsis

From 6eafa6b2e016dd1dc691ac9ec25f67599d3b3e07 Mon Sep 17 00:00:00 2001
From: Gerardo Rodriguez <mr.gerardo.rodriguez@gmail.com>
Date: Tue, 26 Jul 2022 16:57:50 -0700
Subject: [PATCH 3/4] Move aria-hidden to li

---
 src/components/pagination/pagination.twig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/components/pagination/pagination.twig b/src/components/pagination/pagination.twig
index c94073df3..41d97fa35 100644
--- a/src/components/pagination/pagination.twig
+++ b/src/components/pagination/pagination.twig
@@ -5,7 +5,12 @@
   <{{ label_tag_name }} id="{{ label_id }}" class="u-hidden-visually">Pagination</{{ label_tag_name }}>
   <ul class="c-pagination__items" role="list">
     {% for page in pagination.pages %}
-      <li class="c-pagination__item">
+      <li
+        class="c-pagination__item"
+        {% if page.title == '&hellip;' or page.title == '…' %}
+          aria-hidden="true"
+        {% endif %}
+      >
         {% if page.current %}
           <a class="c-pagination__action" href="{{ page.link }}" aria-current="page">
             <span class="u-hidden-visually">Page</span>
@@ -28,12 +33,7 @@
           </a>
         {% else %}
           {# Fallback for non-link pages like ellipsis gaps for first/last pages #}
-          <span
-            class="c-pagination__action"
-            {% if page.title == '&hellip;' or page.title == '…' %}
-              aria-hidden="true"
-            {% endif %}
-          >
+          <span class="c-pagination__action">
             {{ page.title }}
           </span>
         {% endif %}

From 2fb1a4464bb458b41bec7ac71705d8847ac3265e Mon Sep 17 00:00:00 2001
From: Gerardo Rodriguez <mr.gerardo.rodriguez@gmail.com>
Date: Wed, 27 Jul 2022 11:40:17 -0700
Subject: [PATCH 4/4] PR feedback, repeat li

---
 src/components/pagination/pagination.twig | 36 ++++++++++++++---------
 1 file changed, 22 insertions(+), 14 deletions(-)

diff --git a/src/components/pagination/pagination.twig b/src/components/pagination/pagination.twig
index 41d97fa35..203e53ef3 100644
--- a/src/components/pagination/pagination.twig
+++ b/src/components/pagination/pagination.twig
@@ -5,39 +5,47 @@
   <{{ label_tag_name }} id="{{ label_id }}" class="u-hidden-visually">Pagination</{{ label_tag_name }}>
   <ul class="c-pagination__items" role="list">
     {% for page in pagination.pages %}
-      <li
-        class="c-pagination__item"
-        {% if page.title == '&hellip;' or page.title == '…' %}
-          aria-hidden="true"
-        {% endif %}
-      >
-        {% if page.current %}
+      {% if page.current %}
+        <li class="c-pagination__item">
           <a class="c-pagination__action" href="{{ page.link }}" aria-current="page">
             <span class="u-hidden-visually">Page</span>
             <span class="c-pagination__number">{{ page.title }}</span>
           </a>
-        {% elseif page.link and page.link == pagination.prev.link %}
+        </li>
+      {% elseif page.link and page.link == pagination.prev.link %}
+        <li class="c-pagination__item">
           <a class="c-pagination__action is-previous" href="{{ page.link }}">
             <span class="u-hidden-visually">Previous: Page</span>
             <span class="c-pagination__number">{{ page.title }}</span>
           </a>
-        {% elseif page.link and page.link == pagination.next.link %}
+        </li>
+      {% elseif page.link and page.link == pagination.next.link %}
+        <li class="c-pagination__item">
           <a class="c-pagination__action is-next" href="{{ page.link }}">
             <span class="u-hidden-visually">Next: Page</span>
             <span class="c-pagination__number">{{ page.title }}</span>
           </a>
-        {% elseif page.link %}
+        </li>
+      {% elseif page.link %}
+        <li class="c-pagination__item">
           <a class="c-pagination__action" href="{{ page.link }}">
             <span class="u-hidden-visually">Page</span>
             <span class="c-pagination__number">{{ page.title }}</span>
           </a>
-        {% else %}
-          {# Fallback for non-link pages like ellipsis gaps for first/last pages #}
+        </li>
+      {% else %}
+        {# Fallback for non-link pages like ellipsis gaps for first/last pages #}
+        <li
+          class="c-pagination__item"
+          {% if page.title == '&hellip;' or page.title == '…' %}
+            aria-hidden="true"
+          {% endif %}
+        >
           <span class="c-pagination__action">
             {{ page.title }}
           </span>
-        {% endif %}
-      </li>
+        </li>
+      {% endif %}
     {% endfor %}
   </ul>
 </nav>