From 0c21b4356657ff4f72b53d7e757bba84a2872d1e Mon Sep 17 00:00:00 2001 From: Tyler Sticka Date: Wed, 3 Aug 2022 09:29:25 -0700 Subject: [PATCH 1/2] Set a default `border-width` Fixes a bug where our legacy utility classes would display a border on all edges regardless of direction. --- src/utilities/border/border.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/utilities/border/border.scss b/src/utilities/border/border.scss index 5b8292f54..95ff991c6 100644 --- a/src/utilities/border/border.scss +++ b/src/utilities/border/border.scss @@ -4,11 +4,15 @@ * To improve the convenience of using these classes without having to specify * a border style and color every time, we use the `:where` selector to set some * reasonable defaults with no specificity depth. + * + * 1. Set a default `border-width` so legacy utility classes won't immediately + * display visible borders on all sides. */ :where([class^='u-border'], [class*=' u-border']) { border-color: var(--theme-color-border-text-group); border-style: solid; + border-width: 0; /* 1 */ } /** From 9b5516a30dc8520a340e7af5679a3afed8392d03 Mon Sep 17 00:00:00 2001 From: Tyler Sticka Date: Wed, 3 Aug 2022 09:31:49 -0700 Subject: [PATCH 2/2] Add changeset --- .changeset/lazy-turkeys-eat.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/lazy-turkeys-eat.md diff --git a/.changeset/lazy-turkeys-eat.md b/.changeset/lazy-turkeys-eat.md new file mode 100644 index 000000000..9518260b2 --- /dev/null +++ b/.changeset/lazy-turkeys-eat.md @@ -0,0 +1,5 @@ +--- +'@cloudfour/patterns': patch +--- + +Prevent border utility classes from accidentally setting `border-width` on all edges