User logout redirect #13

Merged
merged 2 commits into from Apr 27, 2012

Projects

None yet

4 participants

willrax commented Apr 27, 2012

Changed the logout link to redirect to the login screen after destroying the user session.

@kevzettler kevzettler was assigned Apr 27, 2012
Contributor

@kevzettler I just checked this. Good to merge.

Contributor

@HashNuke

Any idea if this will effect the casfuji logout flow?

def after_sign_out_path_for(resource_or_scope)      
  root_path     
end
Contributor

no it wont. it's just using the rails helper for links.

Akash Manohar J
http://akash.im
@HashNuke

On Friday 27 April 2012 at 12:12 PM, Kev Zettler wrote:

@HashNuke

Any idea if this will effect the casfuji logout flow?

def after_sign_out_path_for(resource_or_scope) 
root_path 
end

--- 
Reply to this email directly or view it on GitHub:
https://github.com/cloudfuji/kandan/pull/13#issuecomment-5375231


Contributor

Also devise logout now requires DELETE request to logout. (it was GET in the older versions). This pull request fixes that too.

Akash Manohar J
http://akash.im
@HashNuke

On Friday 27 April 2012 at 12:12 PM, Kev Zettler wrote:

@HashNuke

Any idea if this will effect the casfuji logout flow?

def after_sign_out_path_for(resource_or_scope) 
root_path 
end

--- 
Reply to this email directly or view it on GitHub:
https://github.com/cloudfuji/kandan/pull/13#issuecomment-5375231


Contributor

This fixes #5

willrax commented Apr 27, 2012

@kevzettler @HashNuke

i think it turned out that

def after_sign_out_path_for(resource_or_scope)      
  root_path     
end

wasn't needed in the end.

Contributor

@willrax

Can we drop it from the pull request then?

@kevzettler kevzettler merged commit f9242f0 into cloudfuji:master Apr 27, 2012
Contributor

closes #5

Contributor

Shouldn't :method => :destroy be :method => :delete?

Contributor
HashNuke commented May 8, 2012

@MichaelEvans agree. the devise http request method for logout is :delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment