Hello. #32

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@sonnyp

sonnyp commented Oct 30, 2011

Just few minor improvements.

@@ -17,7 +17,8 @@ var serverInfo = 'node-static/' + this.version.join('.');
this.store = {};
this.indexStore = {};
-this.Server = function (root, options) {
+this.Server = function (root, options, indexFile) {

This comment has been minimized.

@phstc

phstc Aug 18, 2012

Collaborator

Hey!

Can the indexFile be an option?

options["indexFile"] = "index.html"

@phstc

phstc Aug 18, 2012

Collaborator

Hey!

Can the indexFile be an option?

options["indexFile"] = "index.html"

@@ -47,7 +48,7 @@ this.Server = function (root, options) {
};
this.Server.prototype.serveDir = function (pathname, req, res, finish) {
- var htmlIndex = path.join(pathname, 'index.html'),
+ var htmlIndex = path.join(pathname, this.indexFile || 'index.html'),

This comment has been minimized.

@phstc

phstc Aug 18, 2012

Collaborator

this.options["indexFile"] || "index.html" ???

@phstc

phstc Aug 18, 2012

Collaborator

this.options["indexFile"] || "index.html" ???

@phstc

This comment has been minimized.

Show comment
Hide comment
@phstc

phstc Aug 18, 2012

Collaborator

Hey @sonnyp!

I made few comments, could you check them?

Collaborator

phstc commented Aug 18, 2012

Hey @sonnyp!

I made few comments, could you check them?

@phstc phstc closed this Apr 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment