Compatibility with node 0.8.0 #57

Merged
merged 1 commit into from Jun 28, 2012

Conversation

Projects
None yet
7 participants
Contributor

hlegendre commented Jun 27, 2012

Hi,

I removed the "require('sys')", because 'sys' has been renamed to 'util' and now throws when required.
It appears that it was not used anyway...
I do not have a previous version of node to test if something is now broken but it should work.

Hugues

domenic commented Jun 27, 2012

See #38, #44, #45, #47, #48, #49, #50. This project is pretty dead. We have a fork with this and other fixes at https://github.com/pbouzakis/node-static/commits/patches/; feel free to use that instead.

Collaborator

indexzero commented Jun 27, 2012

@domenic Would you like to become the core maintainer of this project? We don't use it anymore at Nodejitsu (we use ecstatic, but it would be good to see it carry on in the mainline.

domenic commented Jun 27, 2012

@indexzero I'd love to!

Collaborator

indexzero commented Jun 27, 2012

@domenic What's your npm username? I'll add you as an owner.

@cloudhead Can you add @domenic as a collaborator on this repo?

domenic commented Jun 27, 2012

@indexzero I'm domenicdenicola according to npm. Thanks!

Collaborator

indexzero commented Jun 27, 2012

@domenic Great. Once @cloudhead adds you as a collaborator here, merge in your changes and publish to npm.

@phstc phstc added a commit that referenced this pull request Jun 28, 2012

@phstc phstc Merge pull request #57 from hlegendre/master
Compatibility with node 0.8.0
b184ea4

@phstc phstc merged commit b184ea4 into cloudhead:master Jun 28, 2012

finally! nice work 👍

Thanks for the fix! At the moment, npm update node-static points to the old version. I am not very familiar with npm but I think we need a publish? In the meantime people with problems can remove the line "sys = require('sys')," from ./node_modules/node-static/lib/node-static.js

that requires "version" : "0.5.9",++ in package.json

Collaborator

phstc commented Jun 28, 2012

@michaelwittig I'm waiting @cloudhead to add me on npm to publish a new version. https://twitter.com/pablocantero/status/218154828394799104

Until he adds me you can use

  , "dependencies": {
    "node-static": "git://github.com/cloudhead/node-static.git"
  }

@gabipetrovay why it requires >= 0.5.9?

i.e.: that requires a bump in the version number. i.e. (0.5.9)++. i.e. increment the module version. And since that can be either: 0.5.10 or 0.6.0, you have: (0.5.9)++

Collaborator

phstc commented Jun 28, 2012

Sorry! Sorry!

I don't know why, but I was thinking about node version... my mistake! 😞

That's right, I already changed the version.

 # node-static.js
 this.version = [0, 6, 0];

and

 # package.json
 "version"       : "0.6.0",

I'm waiting @cloudhead to add me on npm to publish a new version and push these changes.

we've been waiting for @cloudhead to do things for the past 6 months, isaacs has explicitly said he can step in to make the required change, you just need to ask him https://twitter.com/izs/statuses/197711753918955521

domenic commented Jun 28, 2012

Haha so between me with npm publish privileges and @phstc with GitHub commit privileges we can almost develop this thing.

Let me see if I can just pull down the code and publish. @phstc do you have the ability to add me as a maintainer?

EDIT: I can't publish until someone bumps the package.json version -_-.

Collaborator

indexzero commented Jun 28, 2012

@phstc You now have npm publish rights. I was waiting on giving those to you @domenic until you had commit rights. Generally it's bad to have the git repo and the npm module out of sync imho.

Collaborator

indexzero commented Jun 28, 2012

Worth mentioning I'm not an admin on this repo, which is why I've been waiting on Alexis these past few days.

@phstc phstc added a commit that referenced this pull request Jun 28, 2012

@phstc phstc New version 0.6.0. Related to #57 ffda8e3
Collaborator

phstc commented Jun 28, 2012

Let me see if I can just pull down the code and publish. @phstc do you have the ability to add me as a maintainer?

Sorry, I don't. I'm not an admin.

@indexzero thank you, I published the new version 0.6.0! http://search.npmjs.org/#/node-static

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment