Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

call ReadableStream#resume() on the request #93

Merged
merged 1 commit into from

2 participants

@aaronj1335

in node v0.10, you must call resume() in order to get the 'end'
event
. this adds the call on the request handler.

this adds the resume() call to the cli. it shouldn't cause any
backwards-incompatible changes.

@aaronj1335 aaronj1335 call ReadableStream#resume() on the request
in node v0.10, [you must call `resume()` in order to get the 'end'
event][node_zero_ten]. this adds the call on the request handler.

this adds the `resume()` call to the cli. it shouldn't cause any
backwards-incompatible changes.

[node_zero_ten]: http://blog.nodejs.org/2012/12/20/streams2/
5e02b21
@aaronj1335

the unit tests seem to be broken in node v0.10, and i'm guessing it's for the same reason. i think we may also want to update the read me.

@aaronj1335

after pulling the changes from #92 the unit tests are all working for node v0.10, though i think the readme may still need to be updated with the resume() calls.

@phstc phstc merged commit 2f818f3 into cloudhead:master
@aaronj1335 aaronj1335 deleted the aaronj1335:call_resume branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 2, 2013
  1. @aaronj1335

    call ReadableStream#resume() on the request

    aaronj1335 authored
    in node v0.10, [you must call `resume()` in order to get the 'end'
    event][node_zero_ten]. this adds the call on the request handler.
    
    this adds the `resume()` call to the cli. it shouldn't cause any
    backwards-incompatible changes.
    
    [node_zero_ten]: http://blog.nodejs.org/2012/12/20/streams2/
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  bin/cli.js
View
2  bin/cli.js
@@ -97,7 +97,7 @@ require('http').createServer(function (request, response) {
log(request, response);
}
});
- });
+ }).resume();
}).listen(+argv.port);
console.log('serving "' + dir + '" at http://127.0.0.1:' + argv.port);
Something went wrong with that request. Please try again.