call ReadableStream#resume() on the request #93

Merged
merged 1 commit into from Apr 11, 2013

Conversation

Projects
None yet
2 participants
@aaronj1335
Contributor

aaronj1335 commented Apr 2, 2013

in node v0.10, you must call resume() in order to get the 'end'
event
. this adds the call on the request handler.

this adds the resume() call to the cli. it shouldn't cause any
backwards-incompatible changes.

call ReadableStream#resume() on the request
in node v0.10, [you must call `resume()` in order to get the 'end'
event][node_zero_ten]. this adds the call on the request handler.

this adds the `resume()` call to the cli. it shouldn't cause any
backwards-incompatible changes.

[node_zero_ten]: http://blog.nodejs.org/2012/12/20/streams2/
@aaronj1335

This comment has been minimized.

Show comment Hide comment
@aaronj1335

aaronj1335 Apr 2, 2013

Contributor

the unit tests seem to be broken in node v0.10, and i'm guessing it's for the same reason. i think we may also want to update the read me.

Contributor

aaronj1335 commented Apr 2, 2013

the unit tests seem to be broken in node v0.10, and i'm guessing it's for the same reason. i think we may also want to update the read me.

@aaronj1335

This comment has been minimized.

Show comment Hide comment
@aaronj1335

aaronj1335 Apr 8, 2013

Contributor

after pulling the changes from #92 the unit tests are all working for node v0.10, though i think the readme may still need to be updated with the resume() calls.

Contributor

aaronj1335 commented Apr 8, 2013

after pulling the changes from #92 the unit tests are all working for node v0.10, though i think the readme may still need to be updated with the resume() calls.

phstc added a commit that referenced this pull request Apr 11, 2013

Merge pull request #93 from aaronj1335/call_resume
call ReadableStream#resume() on the request

@phstc phstc merged commit 2f818f3 into cloudhead:master Apr 11, 2013

@aaronj1335 aaronj1335 deleted the aaronj1335:call_resume branch Apr 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment